Enter keypress on new row in Storage doesn't work
In Local / Session storage data grids, you can click in to activate
editing of the last row, but you can't press <enter>. This is due to a
bug in the implementation of focus detection, in which the editor only
checks to see if the overarching data grid IS the currently-focused
element, not whether the data grid CONTAINS the currently-focused
element.
This bug blocked keyboard-only users from adding a new entry to the
Local / Session Storage tables.
Bug: 1394870
Change-Id: I433d95b5eae37632075b84326ddc1d211f13721b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4066165
Reviewed-by: Changhao Han <[email protected]>
Commit-Queue: Robert Paveza <[email protected]>
diff --git a/front_end/ui/legacy/components/data_grid/DataGrid.ts b/front_end/ui/legacy/components/data_grid/DataGrid.ts
index 412edbf437037f24065393f4a4780478e32c00f7..98286092e74d91bd66f534e0465c9ce878029fb9 100644
--- a/front_end/ui/legacy/components/data_grid/DataGrid.ts
+++ b/front_end/ui/legacy/components/data_grid/DataGrid.ts
@@ -1183,8 +1183,8 @@ nextSelectedNode.reveal();
nextSelectedNode.select(); }+ this.deleteCallback = deleteCallback; * 1. Redistributions of source code must retain the above copyright- * @description Default Accessible Text for a Datagrid. This text is read to the user by a // crbug.com/1005449, crbug.com/1329956 // navigational or delete keys pressed but current DataGrid panel has lost focus; // re-focus to ensure subsequent keydowns can be registered within this DataGrid
