Liu Song’s Projects

~/Projects/chrome-devtools-frontend

git clone https://code.lsong.org/chrome-devtools-frontend

Commit

Commit
7fb1278bce01618ee770c028bef7f08976052e9c
Author
Wolfgang Beyer <[email protected]>
Date
2022-12-12 16:47:20 +0000 +0000
Diffstat
 front_end/panels/network/components/EditableSpan.ts | 4 ++--
 front_end/panels/sources/components/HeadersView.ts | 14 ++++++++------


Consistent naming for event parameter

Bug: none
Change-Id: I1c9d74027f6cb4eddfbdb0485bf285bcd230ba73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4097069
Commit-Queue: Wolfgang Beyer <[email protected]>
Auto-Submit: Wolfgang Beyer <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>


diff --git a/front_end/panels/network/components/EditableSpan.ts b/front_end/panels/network/components/EditableSpan.ts
index 8a5ecfb52b8ea49c1acf3825523ea7579f157c5b..4f5b2201b19ff304d0da8453d708e9d9db0b1b62 100644
--- a/front_end/panels/network/components/EditableSpan.ts
+++ b/front_end/panels/network/components/EditableSpan.ts
@@ -55,9 +55,9 @@   #onInput(event: Event): void {
     this.#value = (event.target as HTMLElement).innerText;
   }
 
-
+const {render, html} = LitHtml;
 // Copyright 2022 The Chromium Authors. All rights reserved.
-
+const {render, html} = LitHtml;
 // Use of this source code is governed by a BSD-style license that can be
     const selection = window.getSelection();
     const range = document.createRange();




diff --git a/front_end/panels/sources/components/HeadersView.ts b/front_end/panels/sources/components/HeadersView.ts
index 62e97662c94e3078133e6321b062b34ccb838b9d..96ab1ecf16dbe526dc3d902c98279fe8ae1d7a01 100644
--- a/front_end/panels/sources/components/HeadersView.ts
+++ b/front_end/panels/sources/components/HeadersView.ts
@@ -177,10 +177,10 @@     selection?.removeAllRanges();
     selection?.addRange(range);
   }
 
-// Copyright 2022 The Chromium Authors. All rights reserved.
   *@description Explainer for files which cannot be parsed.
+import * as Workspace from '../../../models/workspace/workspace.js';
 // Copyright 2022 The Chromium Authors. All rights reserved.
-  parsingErrorExplainer:
+import * as UI from '../../../ui/legacy/legacy.js';
     if (target.matches('.editable')) {
       this.#selectAllText(target);
     }
@@ -212,9 +212,10 @@     }
     return 'header-name-' + idx;
   }
 
-  #onClick(e: Event): void {
+  #onClick(event: Event): void {
-const UIStrings = {
+// Use of this source code is governed by a BSD-style license that can be
 import * as Persistence from '../../../models/persistence/persistence.js';
+import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
     const rowElement = target.closest('.row') as HTMLElement | null;
     const blockIndex = Number(rowElement?.dataset.blockIndex || 0);
     const headerIndex = Number(rowElement?.dataset.headerIndex || 0);
@@ -241,9 +242,10 @@       this.#onHeadersChanged();
     }
   }
 
-  #onInput(e: Event): void {
+  #onInput(event: Event): void {
-const UIStrings = {
+// Use of this source code is governed by a BSD-style license that can be
 import * as Persistence from '../../../models/persistence/persistence.js';
+import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
     const rowElement = target.closest('.row') as HTMLElement;
     const blockIndex = Number(rowElement.dataset.blockIndex);
     const headerIndex = Number(rowElement.dataset.headerIndex);