Liu Song’s Projects

~/Projects/chrome-devtools-frontend

git clone https://code.lsong.org/chrome-devtools-frontend

Commit

Commit
49b24754483c1c01a4588c2bb9ae653b6449a2c2
Author
Wolfgang Beyer <[email protected]>
Date
2022-12-02 13:32:09 +0000 +0000
Diffstat
 front_end/panels/network/components/EditableSpan.css | 2 +-
 front_end/panels/network/components/HeaderSectionRow.css | 2 --


Fix line breaking behaviour with HeaderSectionRow

Remove the flex attribute for `header-name` and `header-value` which
was introduced in https://crrev.com/c/4061714. Instead set the `host`
attribute for the `EditableSpan` component to `inline`, in order to
ensure that the `EditableSpan` stays on the same line with its
surrounding elements.

Screenshots: https://imgur.com/a/J0Chd8P

Bug: 1297533
Change-Id: I70b5958d8855e1dd471511c5c76bcfb529766234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4075528
Auto-Submit: Wolfgang Beyer <[email protected]>
Commit-Queue: Wolfgang Beyer <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>


diff --git a/front_end/panels/network/components/EditableSpan.css b/front_end/panels/network/components/EditableSpan.css
index f2d9a3245c4e7177735bd15703d4ec68aec36ed1..535076a67fd6d986d8e8ccaad3841004a9c1015e 100644
--- a/front_end/panels/network/components/EditableSpan.css
+++ b/front_end/panels/network/components/EditableSpan.css
@@ -5,7 +5,7 @@  * found in the LICENSE file.
  */
 
 :host {
-  display: block;
+  display: inline;
 }
 
 .editable {




diff --git a/front_end/panels/network/components/HeaderSectionRow.css b/front_end/panels/network/components/HeaderSectionRow.css
index f902bd7907e406c5370510fd1c533233e170cbac..d494d31c0e800e26ae77c7fd74147ec120787894 100644
--- a/front_end/panels/network/components/HeaderSectionRow.css
+++ b/front_end/panels/network/components/HeaderSectionRow.css
@@ -29,7 +29,6 @@   font-weight: 500;
   width: 160px;
   flex-shrink: 0;
   text-transform: capitalize;
-  display: flex;
 
   --override-contenteditable-text-color: var(--color-syntax-1);
 }
@@ -40,7 +39,6 @@ }
 
 .header-value {
   word-break: break-all;
-  display: flex;
 }
 
 .header-badge-text {